Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping address updates for paypal checkout #3262

Merged
merged 5 commits into from May 25, 2018

Conversation

3 participants
@notbakaneko
Copy link
Contributor

notbakaneko commented May 24, 2018

  • remove shipping address when not required
  • force shipping address when required

@notbakaneko notbakaneko force-pushed the notbakaneko:feature/store/paypal-addresses branch from 7a949b6 to dbe07ba May 24, 2018

@peppy peppy added the store label May 24, 2018

@peppy peppy added this to the May 2018 milestone May 24, 2018

{
$address = $this->order->address;
return (new ShippingAddress())

This comment has been minimized.

@nanaya

nanaya May 24, 2018

Collaborator

A quick check shows that passing array works as well instead of calling all the functions (also applies to all other paypal objects?).

This comment has been minimized.

@notbakaneko

notbakaneko May 24, 2018

Author Contributor

and we're not going to be using any of it

This comment has been minimized.

@nanaya

nanaya May 24, 2018

Collaborator

?_?

I mean something like return new ShippingAddress(['city' => ...]);.

@@ -109,6 +109,7 @@ PAYPAL_URL=https://www.sandbox.paypal.com/cgi-bin/webscr
PAYPAL_MERCHANT_ID=
PAYPAL_CLIENT_ID=
PAYPAL_CLIENT_SECRET=
PAYPAL_NO_SHIPPING_EXPERIENCE_PROFILE=

This comment has been minimized.

@nanaya

nanaya May 24, 2018

Collaborator

..._ID...?

@@ -92,7 +102,7 @@ private function getAmount()
private function getItemList()
{
return (new ItemList())
$itemList = (new ItemList())

This comment has been minimized.

@nanaya

nanaya May 24, 2018

Collaborator

Check requiresShipping in getShippingAddress (returning null accordingly) instead so it can still be just return new ItemList(...)?

@peppy peppy merged commit a5f1af3 into ppy:master May 25, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notbakaneko notbakaneko deleted the notbakaneko:feature/store/paypal-addresses branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.