Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipping address updates for paypal checkout #3262

Merged
merged 5 commits into from
May 25, 2018
Merged

Shipping address updates for paypal checkout #3262

merged 5 commits into from
May 25, 2018

Conversation

notbakaneko
Copy link
Collaborator

  • remove shipping address when not required
  • force shipping address when required

@notbakaneko notbakaneko force-pushed the feature/store/paypal-addresses branch from 7a949b6 to dbe07ba Compare May 24, 2018 05:36
@peppy peppy added this to the May 2018 milestone May 24, 2018
nanaya
nanaya requested changes May 24, 2018
View reviewed changes
app/Libraries/Payments/PaypalCreatePayment.php Outdated
{
$address = $this->order->address;

return (new ShippingAddress())

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

.env.example Outdated
@@ -109,6 +109,7 @@ PAYPAL_URL=https://www.sandbox.paypal.com/cgi-bin/webscr
PAYPAL_MERCHANT_ID=
PAYPAL_CLIENT_ID=
PAYPAL_CLIENT_SECRET=
PAYPAL_NO_SHIPPING_EXPERIENCE_PROFILE=

This comment was marked as off-topic.

Sign in to view

app/Libraries/Payments/PaypalCreatePayment.php Outdated
@@ -92,7 +102,7 @@ private function getAmount()

private function getItemList()
{
return (new ItemList())
$itemList = (new ItemList())

This comment was marked as off-topic.

Sign in to view

@peppy peppy merged commit a5f1af3 into ppy:master May 25, 2018
@notbakaneko notbakaneko deleted the feature/store/paypal-addresses branch June 13, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya requested changes

Assignees
No one assigned
Labels
area:store
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@notbakaneko @nanaya @peppy