Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak lodash #3269

Merged
merged 4 commits into from May 25, 2018
Merged

Unbreak lodash #3269

merged 4 commits into from May 25, 2018

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented May 25, 2018

  • avoid using _ as variable in js
  • restore lodash after loading disqus
  • remove useless interpolation (not related)

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to assume re-overriding _ works

@peppy peppy merged commit 4734846 into ppy:master May 25, 2018
@nanaya nanaya deleted the lodash branch June 28, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants