Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discussion timestamp check #3288

merged 3 commits into from May 31, 2018


Copy link

@nanaya nanaya commented May 31, 2018

Check against all posts in currently selected beatmap. With added bonus of fixing discussion jump by resetting user filter if discussion is by another user.

currentDiscussion is getting even worse but I couldn't find good way to scrap it.

Fixes #3274.

Reset user if target discussion is not the currently selected user.
@notbakaneko notbakaneko self-requested a review May 31, 2018 09:50
Copy link

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion hash seems to disappear from the url if jumpTo is going to a invalid user-discussion combination, but I'm not sure that's an issue...

@notbakaneko notbakaneko merged commit d4f6b56 into ppy:master May 31, 2018
@nanaya nanaya deleted the discussion_mapping branch June 28, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

When filtering mod posts by user, the duplicate discussion check doesn't appear
3 participants