Fix discussion timestamp check #3288

nanaya · 2018-05-31T06:49:09Z

Check against all posts in currently selected beatmap. With added bonus of fixing discussion jump by resetting user filter if discussion is by another user.

currentDiscussion is getting even worse but I couldn't find good way to scrap it.

Fixes #3274.

Reset user if target discussion is not the currently selected user.

notbakaneko

The discussion hash seems to disappear from the url if jumpTo is going to a invalid user-discussion combination, but I'm not sure that's an issue...

nanaya added 2 commits May 31, 2018 15:44

Check timeline without user filter for new discussion

c10ce1d

Fix jumpTo when filtered by user

1a60417

Reset user if target discussion is not the currently selected user.

notbakaneko self-requested a review May 31, 2018 09:50

notbakaneko approved these changes May 31, 2018

View reviewed changes

Merge branch 'master' into discussion_mapping

de06392

notbakaneko merged commit d4f6b56 into ppy:master May 31, 2018

peppy added the resolves issue label Jun 1, 2018

nanaya deleted the discussion_mapping branch June 28, 2018 08:58

Fix discussion timestamp check #3288

Fix discussion timestamp check #3288

nanaya commented May 31, 2018

notbakaneko left a comment

Fix discussion timestamp check #3288

Fix discussion timestamp check #3288

Conversation

nanaya commented May 31, 2018

notbakaneko left a comment

Choose a reason for hiding this comment