New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discussion timestamp check #3288

Merged
merged 3 commits into from May 31, 2018

Conversation

3 participants
@nanaya
Collaborator

nanaya commented May 31, 2018

Check against all posts in currently selected beatmap. With added bonus of fixing discussion jump by resetting user filter if discussion is by another user.

currentDiscussion is getting even worse but I couldn't find good way to scrap it.

Fixes #3274.

nanaya added some commits May 31, 2018

Fix jumpTo when filtered by user
Reset user if target discussion is not the currently selected user.

@notbakaneko notbakaneko self-requested a review May 31, 2018

@notbakaneko

The discussion hash seems to disappear from the url if jumpTo is going to a invalid user-discussion combination, but I'm not sure that's an issue...

@notbakaneko notbakaneko merged commit d4f6b56 into ppy:master May 31, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@peppy peppy added the resolves issue label Jun 1, 2018

@nanaya nanaya deleted the nanaya:discussion_mapping branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment