diff --git a/osu.Game.Rulesets.Mania.Tests/Skinning/TestSceneHoldNote.cs b/osu.Game.Rulesets.Mania.Tests/Skinning/TestSceneHoldNote.cs index 68856cb11ce2..e5098054a320 100644 --- a/osu.Game.Rulesets.Mania.Tests/Skinning/TestSceneHoldNote.cs +++ b/osu.Game.Rulesets.Mania.Tests/Skinning/TestSceneHoldNote.cs @@ -45,14 +45,14 @@ public void TestTailOrigin() AddStep("set tail origin to regular", () => { foreach (var holdNote in CreatedDrawables.SelectMany(d => d.ChildrenOfType())) - ((Bindable)holdNote.Tail.TailOrigin).Value = HoldNoteTailOrigin.Regular; + holdNote.Tail.TailOrigin = HoldNoteTailOrigin.Regular; }); AddStep("change direction to down", () => ScrollingInfo.Direction.Value = ScrollingDirection.Down); AddStep("change direction to up", () => ScrollingInfo.Direction.Value = ScrollingDirection.Up); AddStep("set tail origin to inverted", () => { foreach (var holdNote in CreatedDrawables.SelectMany(d => d.ChildrenOfType())) - ((Bindable)holdNote.Tail.TailOrigin).Value = HoldNoteTailOrigin.Inverted; + holdNote.Tail.TailOrigin = HoldNoteTailOrigin.Inverted; }); AddStep("change direction to down", () => ScrollingInfo.Direction.Value = ScrollingDirection.Down); AddStep("change direction to up", () => ScrollingInfo.Direction.Value = ScrollingDirection.Up); diff --git a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNoteTail.cs b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNoteTail.cs index 4736e78b3400..4db1e9c740b6 100644 --- a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNoteTail.cs +++ b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNoteTail.cs @@ -24,7 +24,15 @@ public partial class DrawableHoldNoteTail : DrawableNote private HoldNoteTailOrigin tailOrigin = HoldNoteTailOrigin.Regular; - public HoldNoteTailOrigin TailOrigin => tailOrigin; + public HoldNoteTailOrigin TailOrigin + { + get => tailOrigin; + set + { + tailOrigin = value; + updateTailOrigin(); + } + } public DrawableHoldNoteTail() : this(null) @@ -38,11 +46,6 @@ public DrawableHoldNoteTail(TailNote tailNote) Origin = Anchor.TopCentre; } - protected override void LoadComplete() - { - base.LoadComplete(); - } - public void UpdateResult() => base.UpdateResult(true); protected override void CheckForResult(bool userTriggered, double timeOffset) => @@ -70,7 +73,6 @@ protected override void ApplySkin(ISkinSource skin, bool allowFallback) { base.ApplySkin(skin, allowFallback); tailOrigin = skin.GetConfig(new ManiaSkinConfigurationLookup(LegacyManiaSkinConfigurationLookups.HoldNoteTailOrigin))?.Value ?? HoldNoteTailOrigin.Regular; - updateTailOrigin(); } protected override void OnDirectionChanged(ValueChangedEvent e)