Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in UpdateableBeatmapBackgroundSprite when reloading is triggered with null beatmap #4527

Open
nekodex opened this Issue Mar 25, 2019 · 0 comments

Comments

2 participants
@nekodex
Copy link
Contributor

nekodex commented Mar 25, 2019

Occurs after an UpdateableBeatmapBackgroundSprite is pushed offscreen/masked and the DelayedLoadUnloadWrapper unloads the content. When the sprite comes back on screen and is reloaded, an ObjectDisposedException is thrown.

Likely a regression due to the behaviour change in #4419 (namely 06b65e0)

...
[runtime:error] 03/25/2019 04:29:28: System.ObjectDisposedException: Attempting to load an already disposed drawable.
[runtime:error] 03/25/2019 04:29:28: Object name: 'BeatmapBackgroundSprite'.
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.<>c__DisplayClass15_1`1.<LoadComponentsAsync>b__2() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 155
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Threading.ScheduledDelegate.RunTask() in C:\projects\osu-framework-a4n7e\osu.Framework\Threading\Scheduler.cs:line 292
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Threading.Scheduler.Update() in C:\projects\osu-framework-a4n7e\osu.Framework\Threading\Scheduler.cs:line 157
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Drawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Drawable.cs:line 420
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 781
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
[runtime:error] 03/25/2019 04:29:28: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree() in C:\projects\osu-framework-a4n7e\osu.Framework\Graphics\Containers\CompositeDrawable.cs:line 794
...

Here's an updated TestCase that reproduces the issue: nekodex@2b7ff08

@peppy peppy added this to the April 2019 milestone Mar 25, 2019

@peppy peppy added the bug label Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.