Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track rotation #1009

Merged
merged 8 commits into from Jul 14, 2017
Merged

Fix track rotation #1009

merged 8 commits into from Jul 14, 2017

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 11, 2017

  • Next track will now play at main menu without music controller visible.
  • Beatmap changes are now disallowed in Player / PlayerLoader / RankingResults (along with ruleset changes).
  • MusicController respects this disabled state.
  • Depends on Expose TrackVirtual osu-framework#891

@peppy peppy requested a review from smoogipoo July 12, 2017 04:47
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@smoogipoo smoogipoo merged commit aa15d36 into ppy:master Jul 14, 2017
@peppy peppy deleted the fix-track-rotation branch July 18, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants