Fix TestDifficultyIconSelectingForDifferentRuleset
potentially failing due to async load
#14957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen:
https://github.com/ppy/osu/runs/3777490864
https://github.com/ppy/osu/pull/14917/checks?check_run_id=3799992067
DrawableCarouselBeatmapSet
loads its difficultySetPanelContent
at a second level of async load (viaDelayedLoadWrapper
) so these failures make sense:osu/osu.Game/Screens/Select/Carousel/SetPanelContent.cs
Lines 70 to 75 in 973c311
Can repro by increasing the load delay to
1000
.