Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load #14957

Merged
merged 1 commit into from Oct 6, 2021

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Oct 5, 2021

As seen:

https://github.com/ppy/osu/runs/3777490864
https://github.com/ppy/osu/pull/14917/checks?check_run_id=3799992067

DrawableCarouselBeatmapSet loads its difficulty SetPanelContent at a second level of async load (via DelayedLoadWrapper) so these failures make sense:

new FillFlowContainer<DifficultyIcon>
{
AutoSizeAxes = Axes.Both,
Spacing = new Vector2(3),
ChildrenEnumerable = getDifficultyIcons(),
},

Can repro by increasing the load delay to 1000.

@smoogipoo smoogipoo merged commit 4e13af6 into ppy:master Oct 6, 2021
@peppy peppy deleted the fix-song-select-test-failure branch October 6, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants