Fix storyboard outro during fail test not being lenient enough #15074
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
fix-storyboard-fail-test-fails
branch
from
90a2d9c
to
26a1e40
Compare
smoogipoo
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to explain with inline comment, but the issue is that the frequency adjust is applied from the update thread onto the audio track. Depending on how the update thread runs (ie. it might not run as frequently as we expect) the duration of the fail process can change.
Hopefully this extra lenience is enough to cover the test failures. If not, the test will need to be restructured further.