New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make leaderboard tabs and active ruleset filter scores #1599

Merged
merged 39 commits into from Dec 21, 2017

Conversation

2 participants
@naoey
Contributor

naoey commented Nov 26, 2017

One thing I'm not certain of is the conditions for the mode parameter of the request. I've noticed trying to fetch with mode=osu for a taiko beatmap returns 403 and the api disconnects. I didn't get around to discerning what scores stable fetches for a taiko beatmap in osu mode, but shouldn't the carousel show only beatmaps playable in the current ruleset?

@naoey

This comment has been minimized.

Show comment
Hide comment
@naoey

naoey Dec 4, 2017

Contributor

So if I understand correctly, I now need to add an OnlineIdentifier property in RulesetInfo, add the identifier in each Ruleset, and add a migration which adds the OnlineIdentifier column?

Contributor

naoey commented Dec 4, 2017

So if I understand correctly, I now need to add an OnlineIdentifier property in RulesetInfo, add the identifier in each Ruleset, and add a migration which adds the OnlineIdentifier column?

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 4, 2017

Member

That does need to be done, in a separate PR.

Member

peppy commented Dec 4, 2017

That does need to be done, in a separate PR.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 10, 2017

Member

Should be updated after #1684 is merged.

Member

peppy commented Dec 10, 2017

Should be updated after #1684 is merged.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 11, 2017

Member

RulesetInfos now have a ShortName. wanna update this to work with that?

Member

peppy commented Dec 11, 2017

RulesetInfos now have a ShortName. wanna update this to work with that?

naoey and others added some commits Dec 20, 2017

peppy added some commits Dec 21, 2017

Remove unnecessary IsLoaded check
We are always loaded at this point.
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 21, 2017

Member

Good job on this one. Finished up the last piece myself so we can merge this in 👍 .

Member

peppy commented Dec 21, 2017

Good job on this one. Finished up the last piece myself so we can merge this in 👍 .

@peppy

peppy approved these changes Dec 21, 2017

@peppy peppy merged commit be526d6 into ppy:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@naoey naoey deleted the naoey:leaderboard-scopes branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment