Fix crash on accessing settings after moving game folder

[peppy]

Bit of an unfortunate one, but in theory the usage of ToLive should be quite isolated. If anything, i can see us reducing the number of places it is used from the current usages.

Closes #16074

[bdach]

CI looks quite red here...

[bdach]

To expand on the the previous point, I'm having a difficult time reviewing these changes because I'm not super sure where it is fine to use .ToLiveUnmanaged() and where it is fine to use .ToLive(). Looks like the only way to validate this would be to check all references and make sure there are no writes to this skinInfo, which is prone to error, and each missed usage is a runtime crash. The compiler could do that for me, but only if IReadOnlyLive<T> existed.

[peppy]

It's definitely a bit of an uncertain one. In these specific cases, the instances are only used for ID based comparison, where the final requery is done on changing skins, but I can understand how this doesn't read great.

diff --git a/osu.Game/OsuGame.cs b/osu.Game/OsuGame.cs
index 9c379de683..a56b25d6c2 100644
--- a/osu.Game/OsuGame.cs
+++ b/osu.Game/OsuGame.cs
@@ -255,10 +255,10 @@ private void load()
                 if (skinInfo == null)
                 {
                     if (guid == SkinInfo.CLASSIC_SKIN)
-                        skinInfo = DefaultLegacySkin.CreateInfo().ToLiveUnmanaged();
+                        skinInfo = DefaultLegacySkin.CreateInfo().ToLive(RealmFactory);
                 }
 
-                SkinManager.CurrentSkinInfo.Value = skinInfo ?? DefaultSkin.CreateInfo().ToLiveUnmanaged();
+                SkinManager.CurrentSkinInfo.Value = skinInfo ?? DefaultSkin.CreateInfo().ToLive(RealmFactory);
             };
             configSkin.TriggerChange();
 
diff --git a/osu.Game/OsuGameBase.cs b/osu.Game/OsuGameBase.cs
index 2e266e32ff..e1ba4ccabf 100644
--- a/osu.Game/OsuGameBase.cs
+++ b/osu.Game/OsuGameBase.cs
@@ -154,7 +154,7 @@ public virtual string Version
 
         private DatabaseContextFactory contextFactory;
 
-        private RealmContextFactory realmFactory;
+        protected RealmContextFactory RealmFactory { get; private set; }
 
         protected override Container<Drawable> Content => content;
 
@@ -198,9 +198,9 @@ private void load(ReadableKeyCombinationProvider keyCombinationProvider)
             dependencies.Cache(RulesetStore = new RulesetStore(contextFactory, Storage));
             dependencies.CacheAs<IRulesetStore>(RulesetStore);
 
-            dependencies.Cache(realmFactory = new RealmContextFactory(Storage, "client", contextFactory));
+            dependencies.Cache(RealmFactory = new RealmContextFactory(Storage, "client", contextFactory));
 
-            new EFToRealmMigrator(contextFactory, realmFactory, LocalConfig).Run();
+            new EFToRealmMigrator(contextFactory, RealmFactory, LocalConfig).Run();
 
             dependencies.CacheAs(Storage);
 
@@ -215,7 +215,7 @@ private void load(ReadableKeyCombinationProvider keyCombinationProvider)
 
             Audio.Samples.PlaybackConcurrency = SAMPLE_CONCURRENCY;
 
-            dependencies.Cache(SkinManager = new SkinManager(Storage, realmFactory, Host, Resources, Audio, Scheduler));
+            dependencies.Cache(SkinManager = new SkinManager(Storage, RealmFactory, Host, Resources, Audio, Scheduler));
             dependencies.CacheAs<ISkinSource>(SkinManager);
 
             EndpointConfiguration endpoints = UseDevelopmentServer ? (EndpointConfiguration)new DevelopmentEndpointConfiguration() : new ProductionEndpointConfiguration();
@@ -239,7 +239,7 @@ private void load(ReadableKeyCombinationProvider keyCombinationProvider)
             dependencies.Cache(ScoreDownloader = new ScoreModelDownloader(ScoreManager, API));
 
             // the following realm components are not actively used yet, but initialised and kept up to date for initial testing.
-            realmRulesetStore = new RealmRulesetStore(realmFactory, Storage);
+            realmRulesetStore = new RealmRulesetStore(RealmFactory, Storage);
 
             dependencies.Cache(realmRulesetStore);
 
@@ -268,7 +268,7 @@ List<ScoreInfo> getBeatmapScores(BeatmapSetInfo set)
             dependencies.Cache(scorePerformanceManager);
             AddInternal(scorePerformanceManager);
 
-            dependencies.Cache(rulesetConfigCache = new RulesetConfigCache(realmFactory, RulesetStore));
+            dependencies.Cache(rulesetConfigCache = new RulesetConfigCache(RealmFactory, RulesetStore));
 
             var powerStatus = CreateBatteryInfo();
             if (powerStatus != null)
@@ -314,7 +314,7 @@ List<ScoreInfo> getBeatmapScores(BeatmapSetInfo set)
 
             base.Content.Add(CreateScalingContainer().WithChildren(mainContent));
 
-            KeyBindingStore = new RealmKeyBindingStore(realmFactory, keyCombinationProvider);
+            KeyBindingStore = new RealmKeyBindingStore(RealmFactory, keyCombinationProvider);
             KeyBindingStore.Register(globalBindings, RulesetStore.AvailableRulesets);
 
             dependencies.Cache(globalBindings);
@@ -380,7 +380,7 @@ protected override void Update()
         {
             base.Update();
 
-            realmFactory.Refresh();
+            RealmFactory.Refresh();
         }
 
         protected override IReadOnlyDependencyContainer CreateChildDependencies(IReadOnlyDependencyContainer parent) =>
@@ -422,7 +422,7 @@ public void Migrate(string path)
 
                 Scheduler.Add(() =>
                 {
-                    realmBlocker = realmFactory.BlockAllOperations();
+                    realmBlocker = RealmFactory.BlockAllOperations();
                     contextFactory.FlushConnections();
 
                     readyToRun.Set();
@@ -502,7 +502,7 @@ protected override void Dispose(bool isDisposing)
             contextFactory?.FlushConnections();
 
             realmRulesetStore?.Dispose();
-            realmFactory?.Dispose();
+            RealmFactory?.Dispose();
         }
     }
 }

OsuGame can be amicably fixed, but the other two cases require a bit more refactoring which potentially makes the class uglier than before. Not sure if it's worth making the change (ie. removing ToLiveUnmanaged usage) just yet, or wait until there's a reason to do so.

[bdach]

Ok, the fact that these usages are only used for equality checks assuages my doubts somewhat. I suppose let's roll with this and see if it backfires, and revisit if it ever does.

[smoogipoo]

I think this is fine?