Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional failures in TestScenePlaySongSelect #16167

Merged
merged 4 commits into from Dec 20, 2021

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Dec 20, 2021

We created 10 sets, which can have random difficulty counts of between 1 and 20. Each difficulty increments the ruleset used. In an.. (un)lucky dealt hand, the correct sequence of difficulty counts could mean there are not enough sets containing the target ruleset for the fixed tests.

As seen here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 20, 2021
@peppy peppy closed this Dec 20, 2021
@peppy peppy reopened this Dec 20, 2021
@peppy
Copy link
Sponsor Member Author

peppy commented Dec 20, 2021

Change seems fine I think.

@peppy peppy merged commit 488e1f8 into ppy:master Dec 20, 2021
@peppy peppy deleted the fix-song-select-test-failure branch December 21, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants