Fix UserProfile crash if displayed User has rank 0 (unranked) in their 30-day history. #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me if that happens, also display "no rank" when hovering over history instead of "#0"
peppy
approved these changes
Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1644 as it was caused by this.
Math.Log(x)returns-Infinityfor x == 0, so when the graph tries to draw, it crashes (since some of its values areInfinity).I fixed this by adding a special case where rank == 0 will be added to the rank graph as
float.MinValue(i think this was intended, graph falls down and out of sight). I also changed it so "#0" would not be displayed in the graph.