New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirmation dialog for "Delete ALL beatmaps" #1676

Merged
merged 11 commits into from Dec 21, 2017

Conversation

4 participants
@Aergwyn
Member

Aergwyn commented Dec 8, 2017

No more accidental deletion by trying to click too fast on Restore all hidden difficulties...

@peppy peppy changed the title from Added confirmation dialog for `Delete ALL beatmaps` to Added confirmation dialog for "Delete ALL beatmaps" Dec 12, 2017

@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo Dec 14, 2017

Contributor

In the future we want to move away from confirmation dialogs, replacing them with undo actions wherever possible, but I'd be okay with this as a temporary solution.

Contributor

smoogipoo commented Dec 14, 2017

In the future we want to move away from confirmation dialogs, replacing them with undo actions wherever possible, but I'd be okay with this as a temporary solution.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 14, 2017

Member

still not sure we need this if #1671 is merged

Member

peppy commented Dec 14, 2017

still not sure we need this if #1671 is merged

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 14, 2017

Member

From the viewpoint of a user destructive actions should always be behind a safety net.
This is not to annoy people that are set out to actually delete but to prevent accidents.
While restorative functionality is always welcome it would still not prevent accidents.
Just imagine someone clicking Delete ALL by mkstake and the panickly spam ESC because the user expects it to cancel. If you're too fast you just closed the game. Iirc this would make the deletion permanent.

Member

Aergwyn commented Dec 14, 2017

From the viewpoint of a user destructive actions should always be behind a safety net.
This is not to annoy people that are set out to actually delete but to prevent accidents.
While restorative functionality is always welcome it would still not prevent accidents.
Just imagine someone clicking Delete ALL by mkstake and the panickly spam ESC because the user expects it to cancel. If you're too fast you just closed the game. Iirc this would make the deletion permanent.

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 14, 2017

Member

Damn send too soon....

So, even if you manage to abort it you luckily have the undo or other methods. But randomly deleting a part of your collection is still undesireable and frankly even confusing.

Member

Aergwyn commented Dec 14, 2017

Damn send too soon....

So, even if you manage to abort it you luckily have the undo or other methods. But randomly deleting a part of your collection is still undesireable and frankly even confusing.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 14, 2017

Member

Eventually there will be a period in time before permanent deletion, to avoid that scenario.

Anyway I'm neutral on this; this button was only there so we could test importing etc. quickly.

Member

peppy commented Dec 14, 2017

Eventually there will be a period in time before permanent deletion, to avoid that scenario.

Anyway I'm neutral on this; this button was only there so we could test importing etc. quickly.

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 15, 2017

Member

Requested changes were adressed, now it's up to if it's wanted or not (or more changes are needed).

Member

Aergwyn commented Dec 15, 2017

Requested changes were adressed, now it's up to if it's wanted or not (or more changes are needed).

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

Can we make the "delete all" button the same pink as dangerous actions on dialogs while we're here?

Member

peppy commented Dec 18, 2017

Can we make the "delete all" button the same pink as dangerous actions on dialogs while we're here?

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 18, 2017

Member

dialog
qq
This is how it would look compared to the dialog button. As close as I could get given that both work quite differently in terms of design.

Member

Aergwyn commented Dec 18, 2017

dialog
qq
This is how it would look compared to the dialog button. As close as I could get given that both work quite differently in terms of design.

@peppy

peppy approved these changes Dec 21, 2017

peppy added some commits Dec 21, 2017

@peppy peppy merged commit efc790e into ppy:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Aergwyn Aergwyn deleted the Aergwyn:add-confirmation-dialog branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment