New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Editor hitobject selections #1690

Merged
merged 33 commits into from Dec 18, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Dec 11, 2017

Completes #1656

Nothing much more than selections at this point - eventually will support movement, etc.

Markers are there, but currently they control the selection size. As discussed, in the future we'll probably want this to "scale" the pattern, but this is an okay starting point for that anyway.

smoogipoo added some commits Nov 30, 2017

Make the dragger attach to objects it surrounds
Plus a lot more implementation.
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

Looks good apart from discussed changes

  • DragSelection -> HitObjectSelectionBox
  • Marker -> Handle
  • Move selection expansion via handles (have it return to its previous selection).

stretch goal: fix sliders only selecting the on-csreen portion

Member

peppy commented Dec 18, 2017

Looks good apart from discussed changes

  • DragSelection -> HitObjectSelectionBox
  • Marker -> Handle
  • Move selection expansion via handles (have it return to its previous selection).

stretch goal: fix sliders only selecting the on-csreen portion

@peppy

peppy approved these changes Dec 18, 2017

@peppy peppy merged commit e59ce0c into ppy:master Dec 18, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:editor-selection-tool branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment