New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand content of BeatmapInfoWedge #1698

Merged
merged 3 commits into from Dec 15, 2017

Conversation

3 participants
@Aergwyn
Member

Aergwyn commented Dec 14, 2017

This

  • adds Spinner Count
  • adds Tooltips to their respective InfoLabels
  • made the TestCase internal like all others
add Spinner Count to BeatmapInfoWedge
- added Tooltips to the respective InfoLabels
- made the TestCase internal like all others
@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo Dec 15, 2017

Contributor

@peppy Are you fine with this? At the moment it's using fa_circle as the icon, but later we're gonna have to get in the icons from osu-web for sliders and bpm anyway...

Contributor

smoogipoo commented Dec 15, 2017

@peppy Are you fine with this? At the moment it's using fa_circle as the icon, but later we're gonna have to get in the icons from osu-web for sliders and bpm anyway...

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 15, 2017

Member

yep

Member

peppy commented Dec 15, 2017

yep

@smoogipoo

👍

@smoogipoo smoogipoo merged commit 94894bf into ppy:master Dec 15, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Aergwyn Aergwyn deleted the Aergwyn:expand-beatmapinfowedge branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment