New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Deselect All button to ModSelectOverlay #1702

Merged
merged 4 commits into from Dec 21, 2017

Conversation

3 participants
@Aergwyn
Member

Aergwyn commented Dec 16, 2017

No description provided.

@smoogipoo

This looks good to me! 👍

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

Could you please add some test steps and asserts to TestCaseMods to test selection and deselection behaviour?

Member

peppy commented Dec 18, 2017

Could you please add some test steps and asserts to TestCaseMods to test selection and deselection behaviour?

@peppy

let's add some tests

@peppy peppy added this to the December 2017 milestone Dec 18, 2017

@smoogipoo

gj 👍

Fixed.

@smoogipoo smoogipoo merged commit 2f02e06 into ppy:master Dec 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Aergwyn Aergwyn deleted the Aergwyn:add-deselect-mods-button branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment