New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyboard controls in gameplay overlays (pause/fail) #1706

Merged
merged 12 commits into from Dec 18, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Dec 18, 2017

Alternative to https://github.com/ppy/osu/pull/1686/files.

Keyboard and mouse controls are condensed into one selection state.

@smoogipoo smoogipoo added this to the December 2017 milestone Dec 18, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

no tests? :(

Member

peppy commented Dec 18, 2017

no tests? :(

@peppy

peppy approved these changes Dec 18, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 18, 2017

Member

💯

Member

peppy commented Dec 18, 2017

💯

@peppy peppy merged commit 7c8a33b into ppy:master Dec 18, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:play-overlay-selections branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment