Fix crash during kiai section on specific map due to negative transform duration #17150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce
Select default skin (triangles)
DETRO - volcanic [Beginner] mapped by spro
https://osu.ppy.sh/beatmapsets/243337#osu/561335
Open map in editor or open any replay and scroll to 1:49 press play
When the 1528BPM section hits game crashes.
logs.zip
Relevant log section:
I also tested this in windows 10, same thing happens.
Why this happens (I'm guessing)
timingPoint.BeatLength - fade_length
becomes negative when BPM>750 as fade_length is 80 (750BPM = 80 ms BeatLength)