New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unnecessary lines on empty BeatmapInfoWedge #1720

Merged
merged 9 commits into from Dec 26, 2017

Conversation

2 participants
@Aergwyn
Member

Aergwyn commented Dec 21, 2017

This bugged me for a while. It hides the unnecessary lines for author and other beatmap stats if there is no real beatmap loaded.

qq

If this is worth exploring I'd also continue on this and look into expanding tests on the BeatmapInfoWedge.

  • extend VisualTests
hide unnecessary lines on empty BeatmapInfoWedge
adding back deleted line

ooops
meh
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 22, 2017

Member

I'd prefer if you avoided references to DummyWorkingBeatmap and just based it on what is present or not present in the WorkingBeatmap itself.

Also further visual tests would be much appreciated in any area of the game (I'm really hoping we can get much more coverage in tests).

Member

peppy commented Dec 22, 2017

I'd prefer if you avoided references to DummyWorkingBeatmap and just based it on what is present or not present in the WorkingBeatmap itself.

Also further visual tests would be much appreciated in any area of the game (I'm really hoping we can get much more coverage in tests).

@peppy peppy added the songselect label Dec 22, 2017

Aergwyn added some commits Dec 22, 2017

remove references to DummyWorkingBeatmap
determine content by data that is present instead
more visual tests for BeatmapInfoWedge
also fix Author showing when not wanted
fix failing tests
1) waiting for loading to finish so Drawables are all present to do asserts on
2) fix NullRef in ResultPage because of removed line in DummyWorkingBeatmap (author one)
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 26, 2017

Member

I've checked with flyte and we both agree that the information should not move vertically even if other pieces are not available. It feels very weird switching between beatmaps where the vertical positioning of text fades to a new location

Member

peppy commented Dec 26, 2017

I've checked with flyte and we both agree that the information should not move vertically even if other pieces are not available. It feels very weird switching between beatmaps where the vertical positioning of text fades to a new location

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 26, 2017

Member

I'm going to look into preventing that then. (Soon™)

Member

Aergwyn commented Dec 26, 2017

I'm going to look into preventing that then. (Soon™)

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 26, 2017

Member

The additional tests added in this PR are useful, at least.

Member

peppy commented Dec 26, 2017

The additional tests added in this PR are useful, at least.

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 26, 2017

Member

Can you try this? It doesn't move anymore and is only half a pixel off the original position.

Member

Aergwyn commented Dec 26, 2017

Can you try this? It doesn't move anymore and is only half a pixel off the original position.

@peppy

peppy approved these changes Dec 26, 2017

@peppy peppy merged commit 50bb9d4 into ppy:master Dec 26, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Aergwyn Aergwyn deleted the Aergwyn:hide-useless-beatmap-info branch Dec 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment