New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another rework of sound handling in taiko #1733

Merged
merged 13 commits into from Dec 26, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Dec 23, 2017

This was originally a fix for taiko strong hits, but developed into a full rework of sound handling in taiko.

Reasoning for removing armed state check in DrawableHitObject.UpdateJudgements:

We potentially want to handle input when State = ArmedState.Hit, such as in the case of taiko strong hits (the first hit sets the ArmedState.Hit state, the second hit sets the Final state).

The State = ArmedState.Miss case is also covered by this Final state, because it's true by default. If a user sets a miss judgement to not final, then we can assume that judgements can still be processed for the hitobject - maybe additional miss judgements or whatever the user intends.

All of this is done by the DrawableHitObject.judgementFinalized property which AllJudged references.

@peppy peppy added this to the December 2017 milestone Dec 23, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 24, 2017

Member

This still seems very broken. A second hit causes the strong circle to just disappear instantly rather than continue its animation.

Also to note: taiko spinners don't play any sounds and sliders seem to play an inappropriate sound when you miss one of their ticks.

Member

peppy commented Dec 24, 2017

This still seems very broken. A second hit causes the strong circle to just disappear instantly rather than continue its animation.

Also to note: taiko spinners don't play any sounds and sliders seem to play an inappropriate sound when you miss one of their ticks.

Show outdated Hide outdated osu.Game.Rulesets.Taiko/Audio/DrumSampleMapping.cs Outdated
Show outdated Hide outdated osu.Game.Rulesets.Taiko/Objects/Swell.cs Outdated

@smoogipoo smoogipoo changed the title from Fix taiko strong hits not being handled to Yet another rework of sound handling in taiko Dec 26, 2017

@peppy peppy added the osu!taiko label Dec 26, 2017

@peppy

peppy approved these changes Dec 26, 2017

@peppy peppy merged commit 2fb619e into ppy:master Dec 26, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-taiko-stronghit branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment