New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special logic to song select to avoid obvious clipping when notifications are displayed #1742

Merged
merged 2 commits into from Dec 26, 2017

Conversation

4 participants
@peppy
Member

peppy commented Dec 25, 2017

Not sure if we will keep this going forward (there will likely be an opaque tab control on the notifications overlay similar to options) but let's go with this for now.

@peppy peppy added this to the December 2017 milestone Dec 25, 2017

@peppy peppy modified the milestone: December 2017 Dec 25, 2017

@Aergwyn

This comment has been minimized.

Show comment
Hide comment
@Aergwyn

Aergwyn Dec 25, 2017

Member

I played around switching between master and this change and moving the whole UI makes it uncomfortable. It's not so noticeable in MainMenu but a moving UI in SongSelect makes me feel a bit dizzy.
Elements on the right side hanging in screen or getting pushed off also appear weird.
qq
Could it maybe only shove in the side that is opened? In a way like resizing the width of the window would appear.

Member

Aergwyn commented Dec 25, 2017

I played around switching between master and this change and moving the whole UI makes it uncomfortable. It's not so noticeable in MainMenu but a moving UI in SongSelect makes me feel a bit dizzy.
Elements on the right side hanging in screen or getting pushed off also appear weird.
qq
Could it maybe only shove in the side that is opened? In a way like resizing the width of the window would appear.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 25, 2017

Member

See my extended commit comment. This will likely be hidden in a similar way to the settings panel

Member

peppy commented Dec 25, 2017

See my extended commit comment. This will likely be hidden in a similar way to the settings panel

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 25, 2017

Member

As a side note, it was always supposed to behave like this. The pushing behaviour regressed when I flattened the screen stack to fix nested input events last week.

Member

peppy commented Dec 25, 2017

As a side note, it was always supposed to behave like this. The pushing behaviour regressed when I flattened the screen stack to fix nested input events last week.

Add special logic to song select to avoid obvious clipping when notif…
…ications are displayed

Not sure if we will keep this going forward (there will likely be an opaque tab control on the notifications overlay similar to options) but let's go with this for now.

@peppy peppy changed the title from Fix null reference in release builds to Add special logic to song select to avoid obvious clipping when notifications are displayed Dec 25, 2017

@smoogipoo

I think this is ok for now, but I think the scrollbar should be hidden.

@smoogipoo smoogipoo merged commit b7c2461 into ppy:master Dec 26, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:improve-screen-offset branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment