New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger null-selection in SongSelect when the last beatmap is hidden #1753

Merged
merged 4 commits into from Dec 26, 2017

Conversation

2 participants
@FreezyLemon
Member

FreezyLemon commented Dec 26, 2017

I also removed the SelectNext() call since it's not needed for removing maps, so it shouldn't be necessary for hiding the last map of a set either (the set disappears for both actions, and it works without that method call in my testing).

Closes #1723 .

@FreezyLemon

This comment has been minimized.

Show comment
Hide comment
@FreezyLemon

FreezyLemon Dec 26, 2017

Member

This also works perfectly fine with #1726 . Just add the !Items.Any() || in front of the selectedBeatmapSet == null similar to how it's done here and it works.

Member

FreezyLemon commented Dec 26, 2017

This also works perfectly fine with #1726 . Just add the !Items.Any() || in front of the selectedBeatmapSet == null similar to how it's done here and it works.

@peppy peppy changed the title from Select dummy map in SongSelect when last map(set) is hidden to Select dummy map in SongSelect when the last beatmap is hidden Dec 26, 2017

Switch to a better way of deciding on null selection
This avoids `SelectionChanged` potentially being invoked multiple times after `selectedBeatmapSet` is already `null`.

@peppy peppy changed the title from Select dummy map in SongSelect when the last beatmap is hidden to Trigger null-selection in SongSelect when the last beatmap is hidden Dec 26, 2017

@peppy

peppy approved these changes Dec 26, 2017

@peppy peppy merged commit 07d7534 into ppy:master Dec 26, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@FreezyLemon FreezyLemon deleted the FreezyLemon:fix-hiding-last-map branch Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment