Calculate sample playback position using screen-space drawable rectangles #17860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are mods which could modify the positioning of the
DrawableHitObject
representation directly, the playback position of the hit samples will still remain unadjusted given that they read from theHitObject
's stored position.Instead, the playback position has changed to now be calculated using the
DrawableHitObject
's actual coordinates at a screen-space level, relative to the parenting container (retrieved by a recursiveParentHitObject?.Parent ?? Parent
).