Add featured artist playlist category #18437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
fa-playlist-category
branch
from
f86c3d4
to
883c6f1
Compare
smoogipoo
previously approved these changes
May 27, 2022
smoogipoo
previously approved these changes
May 27, 2022
|
The border colour on spotlights rooms used to match the badge, now it no longer does:
If that path is to be continued then we probably want to make the featured artist rooms also match as they're using the "open" colour right now:
I'll make the change if you're ok with that. |
|
For reference, here's how these would look with the proposed changes:
|
|
I'm fine with either of the proposals, your call. Probably the standardised single colour makes more sense. |
|
Have pushed my changes, see if you're OK with them. Ended up splitting a colour mapping method for |
bdach
approved these changes
May 27, 2022
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For near-future use. Tested against ppy/osu-web#8967 to work correctly.
Also updates the colour of spotlights playlist to match new specs (see ppy/osu-web#8957).