Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential nullref in TestSceneAutoplay check steps method #19469

Merged
merged 2 commits into from Jul 30, 2022

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jul 30, 2022

CleanShot 2022-07-30 at 10 10 22@2x

Since LoadTrack is now called on constructor in tests, the audio manager is necessary to have in order to construct a virtual track for the beatmap. TestSceneAutoplay however dodgily creates a working beatmap in a non-loaded context just to use it for time reference on the seek step descriptions. Have replaced by only creating the IBeatmap, which is enough for time reference.

I've also updated a few methods that combine the AddStep on the same line as the method declaration, which made it somewhat hard to tell that the code is being executed inside the step because of the indentation difference.

@peppy peppy enabled auto-merge July 30, 2022 07:23
@peppy peppy merged commit ecf7cc7 into ppy:master Jul 30, 2022
@frenzibyte frenzibyte deleted the fix-dodgy-tests branch July 30, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants