New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite BreakOverlay to work with rewinding #2160

Merged
merged 6 commits into from Mar 12, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 3, 2018

No longer relies on Schedule calls (could not be rewound).
Also no longer sucks.

Rewrite BreakOverlay
No longer relies on Schedule calls (could not be rewound).
Also no longer sucks.

@peppy peppy added this to the March 2018 milestone Mar 3, 2018

@peppy peppy added the pending review label Mar 3, 2018

@smoogipoo

smoogipoo requested changes Mar 5, 2018 edited

As commented below...

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 5, 2018

Did you test this with the 2s, 2s and 0.5s, 0.7s, 1s, 2s testcases in TestCaseBreakOverlay, and within Player? Neither of those seem to be working correctly.

@peppy

This comment has been minimized.

Member

peppy commented Mar 5, 2018

Yep, all of these tested!

You need to merge transform fixes first. The high prio one breaking everything game-wide

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 5, 2018

This is without any sort of rewinding though. I mentioned those because they're broken.

@peppy peppy changed the title from Rewrite BreakOverlay to Rewrite BreakOverlay to work with rewinding Mar 7, 2018

peppy and others added some commits Mar 8, 2018

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 12, 2018

lgtm.

@smoogipoo smoogipoo merged commit 89582f7 into ppy:master Mar 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:rewrite-break-overlay branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment