New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taiko drumrolls potentially getting incorrect judgements #2171

Merged
merged 4 commits into from Mar 5, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 5, 2018

No description provided.

@peppy

This comment has been minimized.

Member

peppy commented Mar 5, 2018

Sure we don't want to just ensure non-null for nested lists where a drawable expects to potentially have them?

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 5, 2018

I suppose that's okay.

@peppy

This comment has been minimized.

Member

peppy commented Mar 5, 2018

Not sure this reads better or worse. Didn't realise all the places where nested is read in a case we aren't sure if they are present.

Let's go with lazy for now

@peppy

peppy approved these changes Mar 5, 2018

@peppy peppy changed the title from Fix possible nullref + off-by-one judgements with drumrolls to Fix taiko drumrolls potentially getting incorrect judgements Mar 5, 2018

@peppy peppy added this to the March 2018 milestone Mar 5, 2018

@peppy peppy merged commit e1eb187 into ppy:master Mar 5, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-drumroll-nullref branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment