New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework with FlowContainer changes #2175

Merged
merged 4 commits into from Mar 7, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 6, 2018

Prereqs:

Essentially the main changes are:

  • Change ChangeChildDepth to SetLayoutPosition.
  • Anywhere where depth was used for re-ordering, SetLayoutPosition is now used. This value is typically negated from its original (e.g. notifications, footer buttons), because a -1 depth previously meant being closer to the end of the flow and -1 depth now means being closer to the start of the flow.
  • No more reversal of FlowingChildren, in the custom reversed fill flows - this was previously used to reverse the reversal that the comparer provides, however FlowContainer sorts FlowingChildren in the exact order we want (the non-reversed).

@smoogipoo smoogipoo modified the milestones: March 2018, Candidate Issues Mar 6, 2018

@peppy peppy changed the title from Update framework with flowcontainer changes to Update framework with FlowContainer changes Mar 6, 2018

@peppy

peppy approved these changes Mar 7, 2018

@peppy peppy merged commit b84367c into ppy:master Mar 7, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment