New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework decoders to be more flexible #2191

Merged
merged 4 commits into from Mar 12, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 9, 2018

Prerequisite for skin.ini parsing.

Splits out beatmap and storyboard parsers completely, adds generics. This is a WIP I'm PRing early for review. The remaining issue is to remove the Register methods.

@peppy peppy added this to the March 2018 milestone Mar 9, 2018

this.beatmap = beatmap;
this.beatmap.BeatmapInfo.BeatmapVersion = BeatmapVersion;

This comment has been minimized.

@smoogipoo

smoogipoo Mar 12, 2018

Contributor

This line was removed. Is BeatmapVersion still getting correctly set somewhere else? It's still being used in cases like mania and taiko conversion.

This comment has been minimized.

@peppy

peppy Mar 12, 2018

Member

Looks like a regression, good catch.

@smoogipoo

Looks okay.

@peppy peppy merged commit 1af6a1c into ppy:master Mar 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:decoders branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment