New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check against LegacyID for non-default rulesets #2200

Merged
merged 2 commits into from Mar 12, 2018

Conversation

3 participants
@HoLLy-HaCKeR
Contributor

HoLLy-HaCKeR commented Mar 11, 2018

Custom rulesets wouldn't get detected with a (default) null LegacyID because the client checks for negative LegacyID's.

I also updated the check in the visual tests, but I'm not 100% sure what it's used for.

@Aergwyn

This comment has been minimized.

Member

Aergwyn commented Mar 11, 2018

Wasn't it changed to null just a bit ago? Ahh I can't find it right now. QQ

@HoLLy-HaCKeR

This comment has been minimized.

Contributor

HoLLy-HaCKeR commented Mar 11, 2018

Yeah, and that broke it. See commit e82cad. All IDs were updated but the checks for them weren't.

EDIT: PR #2176 by peppy

@Aergwyn

This comment has been minimized.

Member

Aergwyn commented Mar 11, 2018

Then I recommend changing the checks to only include null as negative IDs shouldn't exist in a database anyways. Personal opinion here though.

@HoLLy-HaCKeR

This comment has been minimized.

Contributor

HoLLy-HaCKeR commented Mar 11, 2018

Alright, I will remove the check for negative IDs.

@peppy

peppy approved these changes Mar 12, 2018

@peppy peppy merged commit 7bf38eb into ppy:master Mar 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment