New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test beatmap from TestCasePlayer into an instantiable class #2205

Merged
merged 6 commits into from Mar 13, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 12, 2018

So that we can use this beatmap elsewhere (editor).

@smoogipoo smoogipoo referenced this pull request Mar 12, 2018

Merged

Create a base TestCaseEditor for rulesets to derive #2206

1 of 1 task complete
[Colours]
Combo1 : 17,254,176

This comment has been minimized.

@peppy

peppy Mar 12, 2018

Member

what happen here o_O

return new TrackVirtual();
}
private class TestTrack : TrackVirtual

This comment has been minimized.

@peppy

peppy Mar 12, 2018

Member

planning on adding more to this class? if not, could possibly just set the length directly

This comment has been minimized.

@smoogipoo

smoogipoo Mar 12, 2018

Contributor

Length setter is protected (probably for a good reason). That's the only reason this class exists.

This comment has been minimized.

@peppy

peppy Mar 12, 2018

Member

hmm, interesting. i get the feeling we'll need to unprotect at some point, but this is fine for now i guess!

@peppy peppy added this to the March 2018 milestone Mar 12, 2018

smoogipoo and others added some commits Mar 13, 2018

@peppy

peppy approved these changes Mar 13, 2018

@peppy peppy merged commit c0248e1 into ppy:master Mar 13, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:test-beatmap branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment