New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a base TestCaseEditor for rulesets to derive #2206

Merged
merged 4 commits into from Mar 13, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 12, 2018

Prereqs:

I have started work on mania to make sure that the code is re-usable/to test the coding overhead. Eventually we're going to want to do this for every ruleset.

@peppy peppy added this to the March 2018 milestone Mar 12, 2018

namespace osu.Game.Tests.Visual
{
public abstract class TestCaseEditor : OsuTestCase

This comment has been minimized.

@peppy

peppy Mar 13, 2018

Member

maybe call this EditorTestCase in line with OsuTestCase and ScreenTestCase?

This comment has been minimized.

@smoogipoo

smoogipoo Mar 13, 2018

Contributor

Fine with TestCaseEditor : EditorTestCase ?

This comment has been minimized.

@peppy

peppy Mar 13, 2018

Member

yeah, just staying in line with the other abstract test case implementations

This comment has been minimized.

@smoogipoo

smoogipoo Mar 13, 2018

Contributor

cool

@peppy

peppy approved these changes Mar 13, 2018

@peppy peppy merged commit c332233 into ppy:master Mar 13, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:base-editor-testcase branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment