New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mods description and adjust multipliers to match stable #2219

Merged
merged 4 commits into from Mar 16, 2018

Conversation

3 participants
@Joehuu
Contributor

Joehuu commented Mar 14, 2018

Resolves #2108. Add mod descriptions to some. And fixes bad wording for mod descriptions on stable. The descriptions might need changing. Did it right this time.

public override string Name => "1K";
public override string Name => "One Key";
public override string ShortenedName => "1K";
public override FontAwesome Icon => FontAwesome.fa_question;

This comment has been minimized.

@Aergwyn

Aergwyn Mar 14, 2018

Member

It's not necessary to set the icon to this as this is the default. This goes for all mods where you do this.

This comment has been minimized.

@Joehuu

Joehuu Mar 14, 2018

Contributor

Will do that. I saw other instances before I made this PR, so that influenced me.

This comment has been minimized.

@Joehuu

Joehuu Mar 14, 2018

Contributor

Won't remove these lines from multimods with at least one icon of one of the mods(i.e. Half Time and Daycore, Half Time has an icon while Daycore does not). Same with Perfect and Sudden Death.

@@ -12,7 +12,7 @@ public abstract class ModDaycore : ModHalfTime
public override string Name => "Daycore";
public override string ShortenedName => "DC";
public override FontAwesome Icon => FontAwesome.fa_question;
public override string Description => "whoaaaaa";
public override string Description => "whoaaaaa...";

This comment has been minimized.

@Aergwyn

Aergwyn Mar 14, 2018

Member

We should stay consistent and user upper case.

@@ -21,7 +21,7 @@ private void load(OsuColour colours)
public AssistedSection()
{
Header = @"Assisted";
Header = @"Special";

This comment has been minimized.

@Aergwyn

Aergwyn Mar 14, 2018

Member

You may want to rename the entire thing to SpecialSection then. It's true that it's not entirely assisting mods.

Joehuu and others added some commits Mar 14, 2018

@peppy peppy changed the title from Fix mods description and multiplier to Improve mods description and adjust multipliers to match stable Mar 16, 2018

@peppy

peppy approved these changes Mar 16, 2018

@peppy peppy merged commit f640b87 into ppy:master Mar 16, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Joehuu Joehuu deleted the Joehuu:mod-fixes branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment