New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DrawableHitObject a CompositeDrawable #2223

Merged
merged 4 commits into from Mar 16, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 15, 2018

No reason for it to be a container. Also potentially they will be a SkinReloadableDrawable soon, so this is kind of a prerequisite for that change.

Make DrawableHitObject a CompositeDrawable
No reason for it to be a container.

@peppy peppy added the code quality label Mar 15, 2018

@peppy peppy added this to the March 2018 milestone Mar 15, 2018

peppy added some commits Mar 16, 2018

@@ -25,7 +25,7 @@ public class DrawableBarLineMajor : DrawableBarLine
public DrawableBarLineMajor(BarLine barLine)
: base(barLine)
{
Add(triangleContainer = new Container
InternalChild = triangleContainer = new Container

This comment has been minimized.

@smoogipoo

smoogipoo Mar 16, 2018

Contributor

Should be AddInternal.

@@ -48,7 +48,7 @@ public DrawableSwell(Swell swell)
{
FillMode = FillMode.Fit;
Add(bodyContainer = new Container
InternalChild = bodyContainer = new Container

This comment has been minimized.

@smoogipoo

smoogipoo Mar 16, 2018

Contributor

Should be AddInternal

@smoogipoo smoogipoo merged commit 18615ce into ppy:master Mar 16, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:drawable-composite-hit-object branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment