New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the way clocks are handled in the Editor #2226

Merged
merged 9 commits into from Mar 19, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 15, 2018

Prereqs:

Due to the changes in #2225, playback/seeking with ways other than scrolling are now broken.

This fixes that by making sure we're referencing the correct clock everywhere.

I've made minimal changes for now just to get things in a working state. We can clean things up afterwards (make a common method to instantiate this between editor and player, etc).

@smoogipoo smoogipoo added this to the March 2018 milestone Mar 15, 2018

@smoogipoo smoogipoo referenced this pull request Mar 15, 2018

Merged

Implement mousewheel time scrolling in the editor #2225

1 of 1 task complete

peppy and others added some commits Mar 16, 2018

Fix null-refing testcase
This would also be fixed with BDL loading children after we're fully loaded ;).
@peppy

This comment has been minimized.

Member

peppy commented Mar 18, 2018

Just thinking, we may want to use DI for these clocks too, rather than passing them down multiple levels (and polluting Ruleset). Was there a reason for keeping them in constructors specifically?

smoogipoo and others added some commits Mar 19, 2018

@peppy

peppy approved these changes Mar 19, 2018

@peppy peppy merged commit 4e4f3fc into ppy:master Mar 19, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-editor-clocks branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment