New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix juice stream droplets spawning in incorrect locations #2231

Merged
merged 4 commits into from Mar 20, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 16, 2018

Closes #2149.

@@ -18,7 +17,6 @@ public class CatchBeatmapConversionTest : BeatmapConversionTest<ConvertValue>
{
protected override string ResourceAssembly => "osu.Game.Rulesets.Catch";
[TestCase("basic"), Ignore("See: https://github.com/ppy/osu/issues/2149")]

This comment has been minimized.

@smoogipoo

smoogipoo Mar 16, 2018

Contributor

Not intended?

This comment has been minimized.

@peppy

peppy Mar 16, 2018

Member

Not intended.

@peppy

This comment has been minimized.

Member

peppy commented Mar 16, 2018

Restored ignored test for now as there's deeper issues.

peppy added some commits Mar 16, 2018

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 20, 2018

This seems okay for now. I'm a little bit weary of the minDistanceToEnd calculation, and if that matches stable, but need FastRandom usage to be fixed and additional tests to be done.

@smoogipoo smoogipoo merged commit 3151940 into ppy:master Mar 20, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-catch-droplets branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment