New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when attempting to select objects that don't have masks #2243

Merged
merged 1 commit into from Mar 19, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Mar 19, 2018

E.g. because DrawableSpinner doesn't (currently) create a mask, SelectionBox was being constructed with 0 hitobjects and then calculating a non-finite size for itself.

Fix attempting to add selection boxes with no selection
E.g. because DrawableSpinner doesn't (currently) create an overlay, SelectionBox was being constructed with 0 hitobjects and then calculating a non-finite size for itself.

@peppy peppy added bug editor labels Mar 19, 2018

@peppy peppy added this to the March 2018 milestone Mar 19, 2018

@peppy

peppy approved these changes Mar 19, 2018

@peppy peppy merged commit caa2827 into ppy:master Mar 19, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-selectionbox-crash branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment