Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Beatmaps decodable as Skins #2253

Merged
merged 8 commits into from Mar 22, 2018

Conversation

2 participants
@peppy
Copy link
Member

peppy commented Mar 20, 2018

  • Includes changes from #2244, merge first.

@peppy peppy added this to the March 2018 milestone Mar 20, 2018

@peppy peppy force-pushed the peppy:beatmap-as-a-skin branch from ad64c7a to d1c2aa7 Mar 20, 2018

@peppy peppy referenced this pull request Mar 20, 2018

Merged

Add skin/beatmap lookup hierarchy #2254

3 of 3 tasks complete

namespace osu.Game.Skinning
{
public class BeatmapSkin : LegacySkin

This comment has been minimized.

@smoogipoo

smoogipoo Mar 22, 2018

Contributor

This gives me the heeby-jeebies. How about LegacyBeatmapSkin.

}
catch (Exception e)
{
Logger.Error(e, "Skin failed to load");

This comment has been minimized.

@smoogipoo

smoogipoo Mar 22, 2018

Contributor

Isn't this going to be super verbose for maps that don't have a skin.ini?

peppy added some commits Mar 22, 2018

@smoogipoo

This comment has been minimized.

Copy link
Contributor

smoogipoo commented Mar 22, 2018

3/4 approving this one while checking other PRs

@smoogipoo smoogipoo merged commit 75ca10a into ppy:master Mar 22, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:beatmap-as-a-skin branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.