New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry not allowing continuing beyond PlayerLoader #2270

Merged
merged 5 commits into from Mar 22, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 21, 2018

Resolves #2265.

@@ -149,6 +149,7 @@ private void pushWhenLoaded()
pushDebounce = Scheduler.AddDelayed(() =>
{
pushDebounce = null;

This comment has been minimized.

@smoogipoo

smoogipoo Mar 22, 2018

Contributor

This might cause issues if done so early (this task is repeating). Can this instead be set when leaving the screen?

peppy added some commits Mar 22, 2018

@peppy peppy merged commit ff41ad9 into ppy:master Mar 22, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-player-loader branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment