Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FocusedTextBox in line with framework changes #2278

Merged
merged 4 commits into from Mar 22, 2018

Conversation

2 participants
@peppy
Copy link
Member

peppy commented Mar 22, 2018

@@ -30,6 +30,8 @@ public bool HoldFocus
}
}

public override bool HandleKeyboardInput => HoldFocus || base.HandleKeyboardInput;

This comment has been minimized.

@smoogipoo

smoogipoo Mar 22, 2018

Contributor

A comment is warranted here, that we need HandleKeyboardInput to be true so we receive focus.

@peppy peppy added this to the March 2018 milestone Mar 22, 2018

@smoogipoo smoogipoo merged commit 242ee8f into ppy:master Mar 22, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:focused-textbox-fix branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.