New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow settings or notifications to be visible at once #2279

Merged
merged 1 commit into from Mar 22, 2018

Conversation

3 participants
@peppy
Member

peppy commented Mar 22, 2018

Resolves #2273.

@LittleEndu

This comment has been minimized.

Contributor

LittleEndu commented Mar 22, 2018

Wasn't them both being visible at the same time a feature? I remember one commit where the background was set to use correct parallax when they both were open at the same time and that makes me think this is intended so making it so they can't be visible at the same time is breaking that.

@LittleEndu

This comment has been minimized.

Contributor

LittleEndu commented Mar 22, 2018

#1735 was the PR. I just remember that on your blog you had a streamable with both of them open at the same time.

@peppy

This comment has been minimized.

Member

peppy commented Mar 22, 2018

Yeah. Gets a bit busy though. The parallax code is still working well here, so wasn't completely wasted.

@smoogipoo smoogipoo merged commit a6bcb0b into ppy:master Mar 22, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-settings-notification-verlay branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment