Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Player trying to load DummyWorkingBeatmap and failing #2288

Merged

Conversation

@FreezyLemon
Copy link
Member

@FreezyLemon FreezyLemon commented Mar 22, 2018

Closes #2283.

Exit();
return;
}

This comment has been minimized.

@smoogipoo

smoogipoo Mar 23, 2018
Contributor

This should be the first thing done in this method, after this.api = api;, just so that we don't cause any unnecessary sample retrievals/etc.

FreezyLemon and others added 3 commits Mar 25, 2018
@smoogipoo smoogipoo removed this from the March 2018 milestone Apr 2, 2018
@smoogipoo smoogipoo merged commit 7a23459 into ppy:master Apr 2, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@FreezyLemon FreezyLemon deleted the FreezyLemon:fix-songselect-exit-notimplemented branch Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.