Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Player trying to load DummyWorkingBeatmap and failing #2288
Conversation
| Exit(); | ||
| return; | ||
| } | ||
This comment has been minimized.
This comment has been minimized.
smoogipoo
Mar 23, 2018
•
Contributor
This should be the first thing done in this method, after this.api = api;, just so that we don't cause any unnecessary sample retrievals/etc.
smoogipoo
added this to the March 2018 milestone
Mar 23, 2018
smoogipoo
added
the
bug
label
Mar 23, 2018
peppy
referenced this pull request
Mar 24, 2018
Closed
Entering song select menu without any beatmaps, then exiting causes System.NotImplementedException #2283
FreezyLemon
and others
added some commits
Mar 25, 2018
smoogipoo
removed this from the March 2018 milestone
Apr 2, 2018
smoogipoo
added
the
resolves issue
label
Apr 2, 2018
smoogipoo
merged commit 7a23459
into
ppy:master
Apr 2, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
FreezyLemon
deleted the
FreezyLemon:fix-songselect-exit-notimplemented
branch
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
FreezyLemon commentedMar 22, 2018
Closes #2283.