New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perfect mod icon #2290

Merged
merged 2 commits into from Mar 23, 2018

Conversation

2 participants
@Joehuu
Contributor

Joehuu commented Mar 23, 2018

The old unicode or whatever showed was blank. Got the unicode from another PR, but how to know what unicode belongs to which icon?

@smoogipoo

LGTM! Eventually we'll probably split out the font assets into sprites I think, so don't worry too much about how to find the unicode endpoints - you'd need the raw font which I don't think we've exposed anywhere.

@smoogipoo smoogipoo merged commit 19900bb into ppy:master Mar 23, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo added this to the March 2018 milestone Mar 23, 2018

@smoogipoo smoogipoo added the mods label Mar 23, 2018

@Joehuu Joehuu deleted the Joehuu:add-perfect-mod-icon branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment