New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API never stopping its thread #2293

Merged
merged 3 commits into from Mar 23, 2018

Conversation

2 participants
@peppy
Member

peppy commented Mar 23, 2018

No description provided.

@peppy peppy added this to the March 2018 milestone Mar 23, 2018

@smoogipoo

This comment has been minimized.

Contributor

smoogipoo commented Mar 23, 2018

Have converted the code to use cancellation tokens instead (.NET Standard does not have Thread.Abort). It looks fine to me. Quick re-review requested @peppy .

@peppy peppy merged commit 802ef3e into ppy:master Mar 23, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:fix-api-abort branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment