Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beatmap background fade not being updated on retry #2296

Merged
merged 2 commits into from Mar 23, 2018

Conversation

2 participants
@smoogipoo
Copy link
Contributor

smoogipoo commented Mar 23, 2018

Fixes #2287.

Background is faded to 1 when Player exits.

@smoogipoo smoogipoo added the bug label Mar 23, 2018

@smoogipoo smoogipoo added this to the March 2018 milestone Mar 23, 2018

@peppy peppy added resolves issue and removed bug labels Mar 23, 2018

@peppy peppy removed this from the March 2018 milestone Mar 23, 2018

@peppy

This comment has been minimized.

Copy link
Member

peppy commented Mar 23, 2018

Hmm, not sure this is what we want to go for..

My vision was that the user settings shouldn't be applied at the loading screen unless the user was making an adjustment.

I'll merge this, but just a heads-up that the behaviour in general is going to need some changing.

@peppy

peppy approved these changes Mar 23, 2018

@peppy peppy merged commit 092ba48 into ppy:master Mar 23, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:fix-background-fade branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.