Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mania playing the wrong/duplicated sounds on playfield keypress #2325

Merged
merged 2 commits into from Mar 29, 2018

Conversation

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Mar 29, 2018

Closes #2266.

@@ -15,5 +16,15 @@ public class HitObjectContainer : CompositeDrawable

public virtual void Add(DrawableHitObject hitObject) => AddInternal(hitObject);
public virtual bool Remove(DrawableHitObject hitObject) => RemoveInternal(hitObject);

protected override int Compare(Drawable x, Drawable y)

This comment has been minimized.

@peppy

peppy Mar 29, 2018
Member

This doesn't affect depth any more, does it?

This comment has been minimized.

@smoogipoo

smoogipoo Mar 29, 2018
Author Contributor

It does - later hitobjects will be below earlier hitobjects.

@peppy
peppy approved these changes Mar 29, 2018
@peppy peppy merged commit 4cc478d into ppy:master Mar 29, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@smoogipoo smoogipoo deleted the smoogipoo:fix-mania-sounds branch Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants