Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screens always load async (fixes stutter when entering editor) #2334

Merged
merged 13 commits into from Apr 23, 2018

Conversation

@peppy
Copy link
Member

@peppy peppy commented Mar 30, 2018

Makes editor not stutter on load, amongst other screens.

Makes editor not stutter on load, amongst other screens.
@peppy peppy added this to the April 2018 milestone Mar 30, 2018
@smoogipoo smoogipoo changed the title Scren async changes in line with framework changes Screen async changes in line with framework changes Apr 2, 2018
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Attempting to enter song select too fast breaks.

@smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 19, 2018

Starting player with dummy beatmap selected:

System.InvalidOperationException: Cannot push an already exited screen.
  at osu.Framework.Screens.Screen.Push (osu.Framework.Screens.Screen screen) [0x0006b] in <e430228582a241528c881254853c30bc>:0 
  at osu.Game.Screens.Play.PlayerLoader.<pushWhenLoaded>b__19_1 () [0x0001e] in <98f8fafee31b4b1b871b9d519aeed96d>:0 
  at osu.Framework.Threading.ScheduledDelegate.RunTask () [0x0000e] in <e430228582a241528c881254853c30bc>:0 
  at osu.Framework.Threading.Scheduler.Update () [0x0024b] in <e430228582a241528c881254853c30bc>:0 
  at osu.Framework.Graphics.Drawable.UpdateSubTree () [0x000a1] in <e430228582a241528c881254853c30bc>:0 
@peppy peppy changed the title Screen async changes in line with framework changes Make screens always load async (fixes stutter when entering editor) Apr 20, 2018
@peppy peppy force-pushed the peppy:async-screens branch 4 times, most recently from a449c3c to 224162f Apr 21, 2018
@peppy peppy force-pushed the peppy:async-screens branch from 224162f to 33e61fa Apr 21, 2018
@peppy peppy force-pushed the peppy:async-screens branch 2 times, most recently from 820b790 to 64ddee5 Apr 21, 2018
@peppy peppy force-pushed the peppy:async-screens branch from 34e76de to ff3d337 Apr 23, 2018
peppy added 2 commits Apr 23, 2018
@peppy peppy force-pushed the peppy:async-screens branch from 6f936b9 to 2d1cef7 Apr 23, 2018
peppy added 2 commits Apr 23, 2018
@peppy peppy merged commit a9ddb46 into ppy:master Apr 23, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy peppy deleted the peppy:async-screens branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.