/osu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screens always load async (fixes stutter when entering editor) #2334

Merged
merged 13 commits into from Apr 23, 2018

Conversation

Reviewers

@smoogipoo smoogipoo

Assignees
No one assigned
Labels
Milestone
  April 2018
2 participants
@peppy @smoogipoo
@peppy
Member

peppy commented Mar 30, 2018 •
edited

Makes editor not stutter on load, amongst other screens.
@peppy
Scren async changes in line with framework changes 
Makes editor not stutter on load, amongst other screens.
31ade98

@peppy peppy added this to the April 2018 milestone Mar 30, 2018

@peppy peppy added performance ux labels Mar 30, 2018

@smoogipoo smoogipoo changed the title from Scren async changes in line with framework changes to Screen async changes in line with framework changes Apr 2, 2018

@smoogipoo

smoogipoo reviewed Apr 2, 2018
View changes

Attempting to enter song select too fast breaks.

@smoogipoo

This comment has been minimized.

Sign in to view
Contributor

smoogipoo commented Apr 19, 2018

Starting player with dummy beatmap selected:

System.InvalidOperationException: Cannot push an already exited screen.
  at osu.Framework.Screens.Screen.Push (osu.Framework.Screens.Screen screen) [0x0006b] in <e430228582a241528c881254853c30bc>:0 
  at osu.Game.Screens.Play.PlayerLoader.<pushWhenLoaded>b__19_1 () [0x0001e] in <98f8fafee31b4b1b871b9d519aeed96d>:0 
  at osu.Framework.Threading.ScheduledDelegate.RunTask () [0x0000e] in <e430228582a241528c881254853c30bc>:0 
  at osu.Framework.Threading.Scheduler.Update () [0x0024b] in <e430228582a241528c881254853c30bc>:0 
  at osu.Framework.Graphics.Drawable.UpdateSubTree () [0x000a1] in <e430228582a241528c881254853c30bc>:0

@peppy peppy dismissed smoogipoo’s stale review Apr 20, 2018

fixed

@peppy peppy changed the title from Screen async changes in line with framework changes to Make screens always load async (fixes stutter when entering editor) Apr 20, 2018

@peppy peppy dismissed smoogipoo’s stale review via 9551b69 Apr 23, 2018

@peppy peppy merged commit a9ddb46 into ppy:master Apr 23, 2018
1 check passed

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:async-screens branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment