Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Judgement Colours #2336

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Implement Judgement Colours #2336

merged 5 commits into from
Apr 4, 2018

Conversation

Frontear
Copy link
Contributor

Resolves: #2251
Alternative to: #2271

@smoogipoo smoogipoo added this to the April 2018 milestone Apr 2, 2018
@smoogipoo smoogipoo removed this from the April 2018 milestone Apr 2, 2018
smoogipoo
smoogipoo previously approved these changes Apr 4, 2018
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me.

In general we don't really do this elsewhere in the codebase.
smoogipoo
smoogipoo previously approved these changes Apr 4, 2018
@smoogipoo smoogipoo merged commit 9558554 into ppy:master Apr 4, 2018
@Frontear Frontear deleted the colours-for-judgements branch April 10, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants