New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScalableContainer irrepairably altering content size #2339

Merged
merged 2 commits into from Apr 3, 2018

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented Apr 2, 2018

Fixes #2192.

Basically:

  1. DrawScale was affected, DrawSize wasn't.
  2. RelativeChildSize was affected when it really shouldn't have been - we should always be working in 0-1 coordinates, without variation by window size.

Also took it a step further and removed one layer of nested containers.

Note: Spinners are now slightly smaller than before because we actually have a 4:3 size container. We'll need to alter this back if we want it to overfill the screen. I've held back on this for now, but let me know if you want me to make this change in this PR.

@peppy

peppy approved these changes Apr 3, 2018

@peppy peppy merged commit 8eefddd into ppy:master Apr 3, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:scalablecontainer-size-fix branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment