Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd beatmap ID lookup to BeatmapSetOverlay #2350
Conversation
naoey
added some commits
Mar 9, 2018
peppy
added this to the April 2018 milestone
Apr 7, 2018
peppy
added
the
online / API
label
Apr 7, 2018
| @@ -66,10 +96,17 @@ public BeatmapSetOverlay() | ||
| RelativeSizeAxes = Axes.Both, | ||
| Colour = OsuColour.Gray(0.2f) | ||
| }, | ||
| loading = new LoadingAnimation | ||
| { | ||
| Anchor = Anchor.Centre, |
This comment has been minimized.
This comment has been minimized.
| { | ||
| Anchor = Anchor.Centre, | ||
| Origin = Anchor.Centre, | ||
| Alpha = 1, |
This comment has been minimized.
This comment has been minimized.
peppy
Apr 10, 2018
Member
because of the way LoadingAnimation is implemented, i recommend you use State = States.Visible here (and replace the FadeIn/FadeOut calls with Show/Hide.
| return; | ||
| } | ||
| header.BeatmapSet = info.BeatmapSet = beatmapSet; |
This comment has been minimized.
This comment has been minimized.
peppy
Apr 10, 2018
Member
i'd rewrite this into
if (beatmapSet == null)
{
...
}
else
{
...
}
with no early return.
Also I'd pass the null down to the header and info components and make them support nulls.
peppy
referenced this pull request
Apr 18, 2018
Merged
Make BeatmapSetOverlay accept nulls everywhere #2416
peppy
added some commits
Apr 18, 2018
peppy
merged commit 6132a5a
into
ppy:master
Apr 20, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
naoey
deleted the
naoey:show-beatmap-id
branch
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
naoey commentedApr 4, 2018
•
edited by peppy