Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beatmap ID lookup to BeatmapSetOverlay #2350

Merged
merged 13 commits into from
Apr 20, 2018
Merged

Conversation

naoey
Copy link
Contributor

@naoey naoey commented Apr 4, 2018

- Handle null value in header and info sections
- Add item to context menu for carousel beatmaps to show details
@peppy peppy added this to the April 2018 milestone Apr 7, 2018
@@ -66,10 +96,17 @@ public BeatmapSetOverlay()
RelativeSizeAxes = Axes.Both,
Colour = OsuColour.Gray(0.2f)
},
loading = new LoadingAnimation
{
Anchor = Anchor.Centre,

This comment was marked as off-topic.

{
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
Alpha = 1,

This comment was marked as off-topic.

return;
}

header.BeatmapSet = info.BeatmapSet = beatmapSet;

This comment was marked as off-topic.

@peppy peppy merged commit 6132a5a into ppy:master Apr 20, 2018
@naoey naoey deleted the show-beatmap-id branch May 3, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants