Add beatmap ID lookup to BeatmapSetOverlay #2350
Merged
Conversation
Contributor
naoey
commented
Apr 4, 2018
•
|
- Handle null value in header and info sections - Add item to context menu for carousel beatmaps to show details
| @@ -66,10 +96,17 @@ public BeatmapSetOverlay() | |||
| RelativeSizeAxes = Axes.Both, | |||
| Colour = OsuColour.Gray(0.2f) | |||
| }, | |||
| loading = new LoadingAnimation | |||
| { | |||
| Anchor = Anchor.Centre, | |||
peppy
Apr 10, 2018
Member
anchor/origin are already specified in base class
anchor/origin are already specified in base class
| { | ||
| Anchor = Anchor.Centre, | ||
| Origin = Anchor.Centre, | ||
| Alpha = 1, |
peppy
Apr 10, 2018
Member
because of the way LoadingAnimation is implemented, i recommend you use State = States.Visible here (and replace the FadeIn/FadeOut calls with Show/Hide.
because of the way LoadingAnimation is implemented, i recommend you use State = States.Visible here (and replace the FadeIn/FadeOut calls with Show/Hide.
| return; | ||
| } | ||
|
|
||
| header.BeatmapSet = info.BeatmapSet = beatmapSet; |
peppy
Apr 10, 2018
Member
i'd rewrite this into
if (beatmapSet == null)
{
...
}
else
{
...
}
with no early return.
Also I'd pass the null down to the header and info components and make them support nulls.
i'd rewrite this into
if (beatmapSet == null)
{
...
}
else
{
...
}
with no early return.
Also I'd pass the null down to the header and info components and make them support nulls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.